Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AppInsights only if Deploy = 'azure' on Suave server #81

Merged
merged 1 commit into from
May 4, 2018
Merged

Enable AppInsights only if Deploy = 'azure' on Suave server #81

merged 1 commit into from
May 4, 2018

Conversation

Zaid-Ajaj
Copy link
Contributor

Running dotnet new SAFE --Server suave adds app insights web part to main Suave web part which doesn't work because that only works if the Deploy = "azure". This PR fixes it.

Also, a couple of names: init => webApi and webPart => webApp because "webApi is part of webApp" makes a bit more sense than "init is part of webPart"

Tested locally, but messed up my branch so I just copy pasted it here ;)

Running `dotnet new SAFE --Server suave` adds app insights web part to main Suave web part which doesn't work because that only works if the `Deploy = "azure"`. This PR fixes it
@forki forki requested a review from isaacabraham May 4, 2018 06:12
@isaacabraham isaacabraham merged commit fdbd860 into SAFE-Stack:master May 4, 2018
@isaacabraham
Copy link
Member

Argh! Good spot. Thanks for doing this.

@Zaid-Ajaj Zaid-Ajaj deleted the patch-1 branch May 4, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants